Skip to content

Add zizmor and fix its findings - #44

Merged
dduugg merged 1 commit into
mainfrom
add-zizmor
Sep 29, 2026
Merged

dduugg merged 1 commit into
mainfrom
add-zizmor

Conversation

@dduugg

@dduugg dduugg commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Adds .github/workflows/zizmor.yml, a caller of rubyatscale/shared-config/.github/workflows/zizmor.yml@main (rubyatscale/shared-config#32), and fixes everything zizmor 1.30.1 reports in this repo so the new check starts clean. The same cleanup went into visualize_packs#113 and pks#55.

  • zizmor mode: the default advanced-security: true, so results go to the Security tab and findings don't fail the job. The caller grants contents: read and security-events: write.
  • Documented ignores for the org's deliberate patterns, worded as in the other repos:
    • unpinned-uses on the @main calls into shared-config, which exist so its fixes propagate.
    • secrets-inherit on secrets: inherit to shared-config. Its workflows declare no workflow_call secrets, so inherit is the only way to pass them.
    • dangerous-triggers on the workflow_run CD trigger, the org's deploy-after-CI-passes pattern.
  • Dependabot: a 7-day cooldown on every entry.

Test plan

  • zizmor 1.30.1 with online audits: 6 findings before, 0 after.
  • actionlint reports nothing new.
  • Fresh Eyes local review: its only findings were about the commit message, which was reworded to match this repo.
  • zizmor / zizmor and the existing checks pass on this PR.

Adds a zizmor workflow that calls rubyatscale/shared-config's reusable
zizmor.yml, and fixes what zizmor 1.30.1 reports here so it starts
clean.

Every workflow here calls into shared-config, so there are no actions to
pin. The @main calls into shared-config, secrets: inherit and the
workflow_run CD trigger get the same documented zizmor ignores the other
rubyatscale repos use. Dependabot entries get a 7-day cooldown.
@dduugg
dduugg requested a review from a team as a code owner September 29, 2026 20:40
@github-project-automation github-project-automation Bot moved this to Triage in Modularity Sep 29, 2026
@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@dduugg
dduugg merged commit 8054cad into main Sep 29, 2026
11 checks passed
@dduugg
dduugg deleted the add-zizmor branch September 29, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants