Repository navigation
Patch seg fault in Zlib::Deflate.new.params(1, Zlib::FILTERED) - #192
Open
FletcherDares wants to merge 1 commit into
Open
FletcherDares wants to merge 1 commit into
FletcherDares wants to merge 1 commit into
Conversation
FletcherDares
marked this pull request as ready for review
November 20, 2026 00:51
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Fix a segfault when
Zlib::Deflate#paramsis called before the first write. The call now applies the requested settingsand returns
nil.Context
A new deflate stream has no output buffer yet (
z->buf == Qnil).deflateParams()can succeed without producing anybytes, but the Ruby wrapper still calls
RSTRING_LEN(z->buf)to update the buffer length. That access can segfault.repro: