Repository navigation
Conversation
zstream_run_func took the temporary lock on the output buffer inside rb_ensure, so when the buffer given as `buffer:` was already locked, for example by `IO#read` in another thread, the failed lock still ran the ensure and released that thread's lock. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A failure of `rb_str_locktmp` escaped `zstream_run_try` before the unconsumed input was put back into the stream, so a retry after the error ended in `Zlib::BufError`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`IO#read` up to Ruby 3.1 resizes a buffer shorter than the read, so `Zlib::Inflate#inflate` failed on the resize before reaching the lock. TruffleRuby's `IO#read` does not lock the buffer at all. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The temporary lock on the output buffer was taken inside
rb_ensure, so when thebuffer:given toZlib::Inflate#inflatewas already locked, for example byIO#readin another thread, the failed lock still ran the ensure and released the other thread's lock.The failed lock also dropped the pending input, so a retry after the error ended in
Zlib::BufError. The input is now put back before the error is raised.Generated with Claude Code