Repository navigation
Conversation
An interrupt such as Thread#raise or Timeout raised in the middle of zstream_run left the unconsumed input in the detached string and next_in pointing to it, which Zlib::Deflate#params could read after it was freed. Put the input back and clear next_in before raising again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Zlib::Inflate#sync also left next_in and avail_in pointing to the input after moving the rest of it to z->input. Clear them there too with a helper shared with zstream_run, so that next_in is always empty outside zstream_run and the pending input lives only in z->input. The adjustment of avail_in for do_inflate is no longer needed since it checks z->input. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An interrupt such as Thread#raise or Timeout raised in the middle of zstream_run left the unconsumed input in the detached string and next_in pointing to it, which Zlib::Deflate#params could read after it was freed. Put the input back and clear next_in before raising again.