Skip to content

test(api): verify push observer contracts externally - #488

Merged
roschaefer merged 2 commits into
mainfrom
test/public-api-contracts
Nov 16, 2026
Merged

roschaefer merged 2 commits into
mainfrom
test/public-api-contracts

Conversation

@roschaefer

@roschaefer roschaefer commented Nov 12, 2026 •

Copy link
Copy Markdown
Owner

Module tests can rely on private implementation details. An external test crate checks push callback-time Git state and verifies that clearing the observer suppresses notifications during a subsequent real push. Each scenario runs in a child process with its own working directory and Git configuration.

Rebased onto main; the testing guidance from #484 is already merged. #489 builds on this PR to reuse the documented push fixture.

Validation: workspace tests, Clippy with warnings denied, formatting and diff checks pass.

@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 39 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5090de20-6070-4d35-b526-5c58006d5cbd
Commits

Reviewing files that changed from the base of the PR and between 5d7e752 and be5e454.

Files selected for processing: 2

  • tests/common/mod.rs
  • tests/push.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Base automatically changed from docs/testing-boundaries to main November 12, 2026 21:06
Module tests can accidentally rely on private implementation details. Exercise callback-time repository state and observer removal through the public library from an isolated external test crate.
@roschaefer
roschaefer force-pushed the test/public-api-contracts branch from 79adb61 to d0610f1 Compare November 16, 2026 16:24
@roschaefer
roschaefer marked this pull request as ready for review November 16, 2026 16:42
@roschaefer

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T17:28:34.867014Z be5e454 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: be5e454afa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@roschaefer
roschaefer merged commit 6379fcd into main Nov 16, 2026
13 checks passed
@roschaefer
roschaefer deleted the test/public-api-contracts branch November 16, 2026 17:29
roschaefer added a commit that referenced this pull request Nov 16, 2026
Separate Rust fixture histories can drift from the scenarios exercised
by Bats and Scrut. Reuse the existing push-ahead recipe through Bash
while keeping both setup and library execution inside the isolated test
child. Its parent owns temporary files, including nested Git setup
directories.

Keep the push-specific fixture beside its scenario so other integration
test crates can reuse the process harness without unused setup helpers.
Forward child output so public API walkthroughs remain visible with
`--nocapture`.

Rebased onto main after #488 merged. #481 reuses this harness for
pause/continue scenarios.

Validation: the external push test, formatting and diff checks pass
after rebasing. The previous full validation also passed workspace
tests, Clippy, and inherited Git overrides with a symlinked TMPDIR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant