Repository navigation
test(api): verify push observer contracts externally - #488
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 39 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Module tests can accidentally rely on private implementation details. Exercise callback-time repository state and observer removal through the public library from an isolated external test crate.
79adb61 to
d0610f1
Compare
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Separate Rust fixture histories can drift from the scenarios exercised by Bats and Scrut. Reuse the existing push-ahead recipe through Bash while keeping both setup and library execution inside the isolated test child. Its parent owns temporary files, including nested Git setup directories. Keep the push-specific fixture beside its scenario so other integration test crates can reuse the process harness without unused setup helpers. Forward child output so public API walkthroughs remain visible with `--nocapture`. Rebased onto main after #488 merged. #481 reuses this harness for pause/continue scenarios. Validation: the external push test, formatting and diff checks pass after rebasing. The previous full validation also passed workspace tests, Clippy, and inherited Git overrides with a symlinked TMPDIR.
Module tests can rely on private implementation details. An external test crate checks push callback-time Git state and verifies that clearing the observer suppresses notifications during a subsequent real push. Each scenario runs in a child process with its own working directory and Git configuration.
Rebased onto main; the testing guidance from #484 is already merged. #489 builds on this PR to reuse the documented push fixture.
Validation: workspace tests, Clippy with warnings denied, formatting and diff checks pass.