Fix outdated claim-unclaimed-rewards text and can-claim check - #1252
Merged
Merged
Conversation
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
0xfornax
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following text in the
claim-unclaimed-rewardsCLI path is outdated and misleading:The text matches the initial RPIP-57 implementation, where the node share was only credited to unclaimed rewards if the withdrawal address could not accept ETH. This was eventually changed so that distributions not called by the node or its withdrawal address always credit the node share to unclaimed rewards, rather than attempting the withdrawal address.
This PR also fixes an issue with the
can-claim-unclaimed-rewardsAPI path. It checked for a failednode.GetUnclaimedRewardsRaw()call rather than a non-zerounclaimedRewards, so it always returnedCanClaim = true.