You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
get-binary exits with 0 when the existing binary is kept #69
When the binary already exists and is not overwritten — the overwrite question is answered "no", or the command runs with --no-interaction — rr get keeps the old file (correct) but exits with 0 and prints [OK] Your project is now ready. Scripts cannot tell that nothing was installed.
GetBinaryCommand::execute() returns 1 with RoadRunner has not been installed only when installBinary() returns null, but installBinary() returns the skipped file as well.
Expected: exit code 1 and the RoadRunner has not been installed warning when the existing binary is kept.
Steps to reproduce
Put any file named rr into an empty directory.
Run rr get --no-config -n there.
The file is unchanged, the exit code is 0.
Additional context
Found by the acceptance tests in #66 (ExistingBinaryTest::failsWhenBinaryIsKept). The DLoad-based implementation in #49 already returns 1 in this case.
Activity