Skip to content

Fix Mopé API URLs, timeouts, and error details - #19

Merged
rhymiz merged 2 commits into
masterfrom
codex/fix-mope-client-0.3.1
Nov 14, 2026
Merged

rhymiz merged 2 commits into
masterfrom
codex/fix-mope-client-0.3.1

Conversation

@rhymiz

@rhymiz rhymiz commented Nov 14, 2026 •

Copy link
Copy Markdown
Owner

Mopé calls lost the /api prefix when joining relative endpoints, and requests had no timeout. Version 0.3.1 keeps both shop routes under /api/ and adds a keyword-only timeout to Mope and Client, defaulting to 5 seconds to connect and 30 seconds between reads. Timeout values must be positive and finite.

HTTP rejections now raise MopeAPIError, a requests.HTTPError subclass exposing validated code, message, data and HTTP status while preserving the response and cause. Wrapped errors and the documentation's unwrapped examples are supported. Malformed error bodies retain the HTTP failure; network and successful-response validation exceptions remain compatible.

The test suite is reduced to 16 cases covering the public payment flows, routing, timeout configuration and actual stalled I/O, API errors, and representative malformed responses. Repetitive field-by-field model checks and standard-library behavior tests were removed. A compact consumer check verifies types from the installed package.

Validation:

  • Ruff lint/format, ty, lock validation and wheel/source builds passed.
  • All 16 tests and installed-package consumer type checks passed on Python 3.11–3.15 in GitHub Actions at d4206a3. A separate negative consumer check rejected all six invalid timeout/error-field uses.
  • An unauthenticated live status fetch reached /api/shop/payment_request/... and raised MopeAPIError with HTTP 401 and Mopé code 1010. No authenticated payment was created.

Prepares release 0.3.1.

@rhymiz
rhymiz merged commit e906bb6 into master Nov 14, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant