Repository navigation
Fix Mopé API URLs, timeouts, and error details - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mopé calls lost the /api prefix when joining relative endpoints, and requests had no timeout. Version 0.3.1 keeps both shop routes under /api/ and adds a keyword-only timeout to Mope and Client, defaulting to 5 seconds to connect and 30 seconds between reads. Timeout values must be positive and finite.
HTTP rejections now raise MopeAPIError, a requests.HTTPError subclass exposing validated code, message, data and HTTP status while preserving the response and cause. Wrapped errors and the documentation's unwrapped examples are supported. Malformed error bodies retain the HTTP failure; network and successful-response validation exceptions remain compatible.
The test suite is reduced to 16 cases covering the public payment flows, routing, timeout configuration and actual stalled I/O, API errors, and representative malformed responses. Repetitive field-by-field model checks and standard-library behavior tests were removed. A compact consumer check verifies types from the installed package.
Validation:
d4206a3. A separate negative consumer check rejected all six invalid timeout/error-field uses.Prepares release 0.3.1.