Repository navigation
GH-43: react to request-level 5xx in the health model - #44
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #43. The health monitor's probe is liveness-only (vLLM
/healthstays 200 while saturated), so overload was invisible to load balancing. This branch feeds each proxied attempt's HTTP status back into the monitor and elevates overloaded nodes to the degraded fallback pool.Fixes follow the approved design (tmp scratch, not committed):
status >= 500is a request-level hit; any other status (incl. 4xx/429) clears the streak.degradedatrequest_overload_threshold(default 3); neverdead(death stays probe-owned). TheGetNodeStatesmerge lifts only probe-healthy nodes.req_streakon/healthreflects it).[gateway] request_overload_threshold(default 3, 0 = default, negative = invalid).Rechecksites untouched.Changes
19b1353..17e55e6)ReportOutcome, streak fields, read-time merge elevation, reload carryover, TTL decayreq_streakin/healthVerification
gofmt / vet /
go test ./.../go test -race(health + api) all green at head.Known gap (follow-up issue filed)
Dropping the streaming guard (
gate.err == nil) is not mutation-gate covered; a truncated-stream 200 would currently clear the streak ("truncated-stream 200 must not clear ReqStreak").