Repository navigation
GH-22: parallel health checks - #24
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Health-check rounds now run in parallel across nodes, so a slow or hung node can no longer stall health-state convergence of the rest of the fleet. Cycle time becomes the slowest node instead of the sum of all nodes.
checkAllspawns one goroutine per node and blocks on async.WaitGroupround barrier; rounds never overlap (effective interval = max(health_interval, round_duration)).tryStart/finishserializes same-node checks, closing the known Recheck/cycle double-count race onConsecutiveFailures.runCheckwrapper (log + continue) means one node's panicking probe can neither crash the gateway nor wedge the guard/barrier.Stop()continues to drain the in-flight round (bounded by the 5s client probe timeout).No config changes, no public API changes; probes (vLLM
/health+ gpu-exporter/metrics) stay sequential within a node. Accepted residual: a Recheck finishing just before a tick can produce at most two sequential probes for one node per interval (each count is a real failed probe).Testing
go test ./... -race -count=1all green; timing-sensitive tests stable at-count=5;go vetclean.Review