Repository navigation
protocols + rig records → private repos (LAB-227) - #288
Merged
1 commit merged intoOct 29, 2026
Merged
1 commit merged into
1 commit merged into
Conversation
Rig-specific protocols and per-rig records leave the public repo so a rig's protocol tweaks never need a webDisplayTools release. Rule: a protocol stays here only if a tool, test, QC profile or fixture depends on it. - Removed (copied first to reiserlab/arena-experiments 8db48e6 and reiserlab/scanimage-2026-bergamo 00bccfd, each with PROVENANCE.md): the three bias_camera_closed_loop_poc* protocols (→ protocols/ww18/), fictrac_bias_test, fictrac_direction_test, fictrac_coupling_bias_fly_test, led_activation_quadrant_test (+ patterns), mode3_drill_1trial (→ protocols/shared/); the three 2P protocols + two pattern folders (→ bergamo protocols/); the ww18 and okey-cokey (ww14) run sheets, handover, dashboard plan, BIAS config and .ps1 start scripts (→ rigs/ww18/, rigs/ww14/). - protocols/index.json drops the moved keys; protocols/MOVED.md maps every old path to its new home. - tests/test-protocol-roundtrip-v3.js parses the 2P sweep from a fixture copy (tests/fixtures/v3_g6_2p_color_led_sweep.yaml). - scripts/make-color-optomotor-patterns.js --gs16 and scripts/make-2p-diagnostic-patterns.js take --out <dir> (the 2P targets are no longer in this repo; without --out they explain where they went and exit 2). - rig/README.md, rig/WINDOWS-TEST.md, the protocol-yaml skill, two course docs and the decision record's "stays" row point at the new locations. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This was referenced Oct 29, 2026
mbreiser
added a commit
that referenced
this pull request
Oct 29, 2026
# Conflicts: # rig/docs/okey-cokey-foxglove-dashboard-plan.md
mbreiser
added a commit
that referenced
this pull request
Oct 29, 2026
mbreiser
added a commit
that referenced
this pull request
Oct 29, 2026
# Conflicts: # rig/docs/okey-cokey-foxglove-dashboard-plan.md
mbreiser
added a commit
that referenced
this pull request
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rig-specific protocols and per-rig records leave the public repo so a rig's protocol tweaks never need a webDisplayTools release (Linear LAB-227). The rule: a protocol stays here only if a tool, test, QC profile or doc fixture depends on it. Everything removed here was copied first, with a
PROVENANCE.mdin each destination:reiserlab/arena-experiments(private, commit8db48e6):protocols/ww18/← the threebias_camera_closed_loop_poc*protocols;protocols/shared/←fictrac_bias_test,fictrac_direction_test,fictrac_coupling_bias_fly_test,led_activation_quadrant_test(+_patterns/),mode3_drill_1trial;rigs/ww18/← the ww18 Windows results;rigs/ww14/← the okey-cokey run sheets, handover, dashboard plan, BIAS config and the two.ps1start scripts.roster.yamlgains theww18andww14rigs.reiserlab/scanimage-2026-bergamo(private, commit00bccfd):protocols/←g6_2p_color_led_sweep(+_patterns/),g6_2x10_2p_diagnostics(+_patterns/),g6_2x10_2p_duty_sweep.Stays public:
protocols/validation/bench_closed_loop_2x10,g6_2x10_smoke,full_experiment,g6_color_optomotor_smoke,g6_color_optomotor_test(+ patterns;rig/tests/test_stimulus.py),opto_intensity_runtime_test,fictrac_closed_loop, the threesoak_*(the Studio Soak dialog names them), allconfigs/rigs/*.yaml(the Studio reads rig YAML only from the site),rig/foxglove/arena-okey-cokey.json(a layoutrig.py --foxgloveloads),rig/tools/ufmf.py+patfile.py(imported by nodes).In this PR:
protocols/index.jsondrops the moved keys;protocols/MOVED.mdmaps every old path to its new home;tests/test-protocol-roundtrip-v3.jsparses the 2P sweep from a fixture copy (tests/fixtures/v3_g6_2p_color_led_sweep.yaml);scripts/make-color-optomotor-patterns.js --gs16andscripts/make-2p-diagnostic-patterns.jstake--out <dir>(without it they name the private repo and exit 2);rig/README.md,rig/WINDOWS-TEST.md, theprotocol-yamlskill, two course docs and the decision record's "stays" row point at the new locations. Pages underdocs/development/that cite old paths are historical and untouched.Notes for the candidate: #285 (
pixi run qc) must switch itsbergamoprofile fromprotocols/g6_2x10_2p_diagnostics.yamltoprotocols/validation/bench_closed_loop_2x10.yaml(the 2P protocol is private now); itsww18/mac/ww14profiles are unaffected. The private copies are already pushed, so this PR can merge as soon as the candidate is validated.Tier
next candidate (together with #285 and #286).
Release notes
reiserlab/arena-experiments,reiserlab/scanimage-2026-bergamo);protocols/MOVED.mdsays where each one went. The site library keeps the validation and demo protocols.Test plan
pixi run test(root): 72/72 files, incl.test-studio-protocols-index,test-protocol-roundtrip-v3(fixture path),test-studio-runtime-vars,test-project-skillsnode scripts/make-2p-diagnostic-patterns.js/--gs16without--outexit 2 with the pointer; with--out <dir>both regenerate their sets (self-verify OK)cd rig && pixi install --locked && pixi run testin the PR worktree: every check passes except the known macOS host-monitor CPU gate (median 0.072 of a core on rig-nodes 0.3.0; fixed by the 0.4.0 re-pin in rig: pin the rig-nodes package set 0.4.0 at its release tag (LAB-338) #286, same as onmain) —test_stimulus.pystill findsg6_color_optomotor_test_patternsarena-experiments(LAB-227 Phase 1, in progress on the rig)pixi run qc -- --tier next --rig ww18on the candidate🤖 Generated with Claude Code