Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D120992289. |
meta-codesync
Bot
changed the title
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 21, 2026
Summary: Source-built CocoaPods frameworks do not automatically expose the source directories behind stable <React/...> umbrella includes. React-FabricComponents exports modal and text headers that consume umbrellas owned by React-Fabric, React-debug, React-rendererdebug, and React-utils, causing dynamic-framework builds to fail while resolving headers such as <React/RendererCore.h>. Add the five owning source directories to React-FabricComponents HEADER_SEARCH_PATHS when frameworks and source-built RNCore are used. Keep prebuilt RNCore unchanged so its <React/...> headers continue to resolve from the prebuilt React.framework. Changelog: [Internal] Differential Revision: D120992289
coado
force-pushed
the
export-D120992289
branch
from
September 21, 2026 14:33
70757b2 to
b379874
Compare
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 21, 2026
Summary: Source-built CocoaPods frameworks do not automatically expose the source directories behind stable <React/...> umbrella includes. React-FabricComponents exports modal and text headers that consume umbrellas owned by React-Fabric, React-debug, React-rendererdebug, and React-utils, causing dynamic-framework builds to fail while resolving headers such as <React/RendererCore.h>. Add the five owning source directories to React-FabricComponents HEADER_SEARCH_PATHS when frameworks and source-built RNCore are used. Keep prebuilt RNCore unchanged so its <React/...> headers continue to resolve from the prebuilt React.framework. Changelog: [Internal] Differential Revision: D120992289
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 21, 2026
Summary: Source-built CocoaPods frameworks do not automatically expose the source directories behind stable <React/...> umbrella includes. React-FabricComponents exports modal and text headers that consume umbrellas owned by React-Fabric, React-debug, React-rendererdebug, and React-utils, causing dynamic-framework builds to fail while resolving headers such as <React/RendererCore.h>. Add the five owning source directories to React-FabricComponents HEADER_SEARCH_PATHS when frameworks and source-built RNCore are used. Keep prebuilt RNCore unchanged so its <React/...> headers continue to resolve from the prebuilt React.framework. Changelog: [Internal] Differential Revision: D120992289
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 21, 2026
Summary: Source-built CocoaPods frameworks do not automatically expose the source directories behind stable <React/...> umbrella includes. React-FabricComponents exports modal and text headers that consume umbrellas owned by React-Fabric, React-debug, React-rendererdebug, and React-utils, causing dynamic-framework builds to fail while resolving headers such as <React/RendererCore.h>. Add the five owning source directories to React-FabricComponents HEADER_SEARCH_PATHS when frameworks and source-built RNCore are used. Keep prebuilt RNCore unchanged so its <React/...> headers continue to resolve from the prebuilt React.framework. Changelog: [Internal] Differential Revision: D120992289
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 21, 2026
Summary: Pull Request resolved: react#58622 Source-built CocoaPods frameworks do not automatically expose the source directories behind stable <React/...> umbrella includes. React-FabricComponents exports modal and text headers that consume umbrellas owned by React-Fabric, React-debug, React-rendererdebug, and React-utils, causing dynamic-framework builds to fail while resolving headers such as <React/RendererCore.h>. Add the five owning source directories to React-FabricComponents HEADER_SEARCH_PATHS when frameworks and source-built RNCore are used. Keep prebuilt RNCore unchanged so its <React/...> headers continue to resolve from the prebuilt React.framework. Changelog: [Internal] Differential Revision: D120992289
coado
force-pushed
the
export-D120992289
branch
2 times, most recently
from
September 21, 2026 19:00
8c035c5 to
539ba16
Compare
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 21, 2026
Summary: Source-built CocoaPods frameworks do not automatically expose the source directories behind stable <React/...> umbrella includes. React-FabricComponents exports modal and text headers that consume umbrellas owned by React-Fabric, React-debug, React-rendererdebug, and React-utils, causing dynamic-framework builds to fail while resolving headers such as <React/RendererCore.h>. Add the five owning source directories to React-FabricComponents HEADER_SEARCH_PATHS when frameworks and source-built RNCore are used. Keep prebuilt RNCore unchanged so its <React/...> headers continue to resolve from the prebuilt React.framework. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D120992289
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 21, 2026
Summary: Source-built CocoaPods frameworks do not automatically expose the source directories behind stable <React/...> umbrella includes. React-FabricComponents exports modal and text headers that consume umbrellas owned by React-Fabric, React-debug, React-rendererdebug, and React-utils, causing dynamic-framework builds to fail while resolving headers such as <React/RendererCore.h>. Add the five owning source directories to React-FabricComponents HEADER_SEARCH_PATHS when frameworks and source-built RNCore are used. Keep prebuilt RNCore unchanged so its <React/...> headers continue to resolve from the prebuilt React.framework. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D120992289
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 21, 2026
Summary: Source-built CocoaPods frameworks do not automatically expose the source directories behind stable <React/...> umbrella includes. React-FabricComponents exports modal and text headers that consume umbrellas owned by React-Fabric, React-debug, React-rendererdebug, and React-utils, causing dynamic-framework builds to fail while resolving headers such as <React/RendererCore.h>. Add the five owning source directories to React-FabricComponents HEADER_SEARCH_PATHS when frameworks and source-built RNCore are used. Keep prebuilt RNCore unchanged so its <React/...> headers continue to resolve from the prebuilt React.framework. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D120992289
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 21, 2026
Summary: Pull Request resolved: react#58622 Source-built CocoaPods frameworks do not automatically expose the source directories behind stable <React/...> umbrella includes. React-FabricComponents exports modal and text headers that consume umbrellas owned by React-Fabric, React-debug, React-rendererdebug, and React-utils, causing dynamic-framework builds to fail while resolving headers such as <React/RendererCore.h>. Add the five owning source directories to React-FabricComponents HEADER_SEARCH_PATHS when frameworks and source-built RNCore are used. Keep prebuilt RNCore unchanged so its <React/...> headers continue to resolve from the prebuilt React.framework. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D120992289
coado
force-pushed
the
export-D120992289
branch
2 times, most recently
from
September 22, 2026 09:26
3e60740 to
87547cf
Compare
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 22, 2026
Summary: Source-built CocoaPods frameworks do not automatically expose the directories behind stable <React/...> umbrella includes. React-FabricComponents exports modal and text headers that consume umbrellas owned by React-Fabric, React-debug, React-rendererdebug, and React-utils. Those headers are also compiled by consuming application targets, which do not inherit React-FabricComponents pod target settings. Add the owning source directories to React-FabricComponents and propagate the four framework header roots to aggregate targets when RNCore is built from source. Keep prebuilt RNCore unchanged so its <React/...> headers continue to resolve from the prebuilt React.framework. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D120992289
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 22, 2026
Summary: Source-built CocoaPods frameworks do not automatically expose the directories behind stable <React/...> umbrella includes. React-FabricComponents exports modal and text headers that consume umbrellas owned by React-Fabric, React-debug, React-rendererdebug, and React-utils. Those headers are also compiled by consuming application targets, which do not inherit React-FabricComponents pod target settings. Add the owning source directories to React-FabricComponents and propagate the four framework header roots to aggregate targets when RNCore is built from source. Keep prebuilt RNCore unchanged so its <React/...> headers continue to resolve from the prebuilt React.framework. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D120992289
Summary: Source-built CocoaPods frameworks do not automatically expose the directories behind stable <React/...> umbrella includes. Exported and generated headers consume umbrellas owned by sibling frameworks, while consuming application and pod targets do not automatically inherit the header roots for those frameworks. Add source-only aggregate paths for the umbrella frameworks used by FabricComponents and React-perflogger, configure the React-timing dependency of React-perflogger with its framework header root, and expose React-bridging to generated module targets. Keep prebuilt RNCore unchanged so its <React/...> headers continue to resolve from the prebuilt React.framework. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D120992289
meta-codesync
Bot
changed the title
coado
force-pushed
the
export-D120992289
branch
from
September 22, 2026 11:28
87547cf to
5f77554
Compare
coado
added a commit
to coado/react-native
that referenced
this pull request
Sep 22, 2026
Summary: Source-built CocoaPods frameworks do not automatically expose the directories behind stable <React/...> umbrella includes. Exported and generated headers consume umbrellas owned by sibling frameworks, while consuming application and pod targets do not automatically inherit the header roots for those frameworks. Add source-only aggregate paths for the umbrella frameworks used by FabricComponents and React-perflogger, configure the React-timing dependency of React-perflogger with its framework header root, and expose React-bridging to generated module targets. Keep prebuilt RNCore unchanged so its <React/...> headers continue to resolve from the prebuilt React.framework. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D120992289
|
This pull request has been merged in 335ef07. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Source-built CocoaPods frameworks do not automatically expose the directories behind stable <React/...> umbrella includes. Exported and generated headers consume umbrellas owned by sibling frameworks, while consuming application and pod targets do not automatically inherit the header roots for those frameworks.
Add source-only aggregate paths for the umbrella frameworks used by FabricComponents and React-perflogger, configure the React-timing dependency of React-perflogger with its framework header root, and expose React-bridging to generated module targets. Keep prebuilt RNCore unchanged so its <React/...> headers continue to resolve from the prebuilt React.framework.
Changelog: [Internal]
Reviewed By: cipolleschi
Differential Revision: D120992289