Skip to content

feat: add hy_AM & sq_AL locales - #725

Open
yoyo837 wants to merge 1 commit into
react-component:masterfrom
yoyo837:feat/locale-hy-am-sq-al
Open

yoyo837 wants to merge 1 commit into
react-component:masterfrom
yoyo837:feat/locale-hy-am-sq-al

Conversation

@yoyo837

@yoyo837 yoyo837 commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

🤔 This PR

  • Add hy_AM (Armenian) and sq_AL (Albanian) locale files.

💡 Motivation

ant-design currently keeps inline Pagination translations for these two languages precisely because these files are missing here — the only 2 of its 73 locale files that define Pagination inline instead of importing from @rc-component/pagination/locale/* (see ant-design#59444, where the missing page_size key surfaced). Adding them upstream lets antd (and any other consumer) use a single source of truth.

📝 Details

  • Values taken verbatim from ant-design's components/locale/hy_AM.ts / sq_AL.ts.
  • page_size values (Էջի չափը, Madhësia e faqes) come from ant-design#59444 by @Chaoqi31 — not yet reviewed by native speakers, corrections welcome.

✅ Verification

  • prettier / eslint / tsc --noEmit pass

Summary by CodeRabbit

  • 新功能
    • 新增亚美尼亚语和阿尔巴尼亚语分页组件文案,涵盖页码导航、每页条目数、跳转及相关提示。

Copilot AI balanced review requested due to automatic review settings September 30, 2026 11:00
@vercel

vercel Bot commented Sep 30, 2026

Copy link
Copy Markdown

@yoyo837 is attempting to deploy a commit to the React Component Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: ecd0c173-fc96-4ae6-bdf2-e81bbebef897

📥 Commits

Reviewing files that changed from the base of the PR and between 0a607d1 and 37aee61.

📒 Files selected for processing (2)
  • src/locale/hy_AM.ts
  • src/locale/sq_AL.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.


Walkthrough

新增亚美尼亚语和阿尔巴尼亚语分页本地化配置。配置包含分页选项、页面导航、每页条目数和跳转相关文案,并作为默认导出提供。

Changes

分页语言配置

Layer / File(s) Summary
新增分页语言配置
src/locale/hy_AM.ts, src/locale/sq_AL.ts
新增亚美尼亚语和阿尔巴尼亚语的分页文案配置,并分别默认导出为 PaginationLocale 类型。

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 37aee

这两种语言的分页配置符合现有结构,且没有发现会阻碍合并的具体问题。

Architecture Summary

Architecture risk: 🔵 Low · up to 37aee

The change affects 1 system.

Changed systems: src

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — src (service) was modified; 2 changed files map to changed impact.

Before / after behavior

  • observed — Modified behavior in src/locale/hy_AM.ts: Adds the Armenian pagination locale object, defining option and navigation labels and exporting it as the default.
  • observed — Modified behavior in src/locale/sq_AL.ts: 新增 PaginationLocale 类型的阿尔巴尼亚语分页配置,提供分页选项、跳转提示、页码导航和页码大小文案,并默认导出该配置。
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 标题准确概括了主要变更,即新增 hy_AM 和 sq_AL 本地化文件。标题简洁、明确,并与 PR 内容一致。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Create a new PR

Warning

Some tools did not complete. Review the errors below.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

小兔翻开分页页,
亚美尼亚文案来报到。
阿尔巴尼亚文案也排好,
前后页与跳转都有标,
每页条数清清楚楚,
兔子满意蹦回草丛。

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.69%. Comparing base (0a607d1) to head (37aee61).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #725   +/-   ##
=======================================
  Coverage   99.69%   99.69%           
=======================================
  Files           4        4           
  Lines         332      332           
  Branches      153      153           
=======================================
  Hits          331      331           
  Misses          1        1           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The locale modules follow existing conventions and contain the required translation keys.

Review effort: Balanced
Findings: None

What changed in this PR

Adds Armenian and Albanian pagination locales, enabling consumers such as Ant Design to use upstream translations consistently.

Changes:

  • Adds complete hy_AM pagination translations.
  • Adds complete sq_AL pagination translations.
File Description
src/​locale/​hy_AM.ts Adds the Armenian locale.
src/​locale/​sq_AL.ts Adds the Albanian locale.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants