Skip to content

media: i2c: arducam_64mp: Fix crop sizes for 9152x6944 and 8000x6000 - #7651

Closed
cbeltranMC wants to merge 1 commit into
raspberrypi:rpi-6.18.yfrom
cbeltranMC:arducam-64mp-crop-fix
Closed

cbeltranMC wants to merge 1 commit into
raspberrypi:rpi-6.18.yfrom
cbeltranMC:arducam-64mp-crop-fix

Conversation

@cbeltranMC

Copy link
Copy Markdown
Contributor

The analog crop reported for these two modes uses the full pixel array size (9248x6944), but the register settings read a smaller area:

  • 8000x6000 reads x 624-8623, y 472-6471 unbinned (0x0344-0x034a), so the crop is 8000x6000 at the existing offset.
  • 9152x6944 reads the full array and then keeps the first 9152 columns (0x0408 = 0, 0x040c = 9152), so the crop is 9152x6944 at offset 0.

Tested on a Pi 5: each mode's image was located inside a full-array capture, confirming the position and 1:1 scale.

Fixes: #7650

The analog crop reported for these two modes uses the full pixel
array size (9248x6944), but the register settings read a smaller
area:

- 8000x6000 reads x 624-8623, y 472-6471 unbinned (0x0344-0x034a),
  so the crop is 8000x6000 at the existing offset.
- 9152x6944 reads the full array and then keeps the first 9152
  columns (0x0408 = 0, 0x040c = 9152), so the crop is 9152x6944
  at offset 0.

Tested on a Pi 5: each mode's image was located inside a full-array
capture, confirming the position and 1:1 scale.

Link: raspberrypi#7650
Signed-off-by: Carlos Beltran <cbeltran@managingcomposites.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

arducam_64mp: crop size for the 8000x6000 and 9152x6944 modes may not match the area actually read out

1 participant