Skip to content

Fix zero-centered gamma parity for ET RMSNorm (#23193) - #23193

Open
chinnadhurai wants to merge 1 commit into
pytorch:mainfrom
chinnadhurai:export-D121895059
Open

chinnadhurai wants to merge 1 commit into
pytorch:mainfrom
chinnadhurai:export-D121895059

Conversation

@chinnadhurai

@chinnadhurai chinnadhurai commented Sep 28, 2026 •

Copy link
Copy Markdown

Summary:

Preserve zero-centered gamma semantics for transformer block and output RMSNorms in both ExecuTorch and rlformers ET paths while leaving Q/K norms unchanged. Preserve output_norm_gain_center_type so center-zero output weights are not shifted.

Authored with assistance from Codex.

Differential Revision: D121895059

@pytorch-bot

pytorch-bot Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/23193

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit 45a262e with merge base 36302a1 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 28, 2026
@linux-foundation-easycla

linux-foundation-easycla Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: chinnadhurai / name: Chinnadhurai Sankar (2142b7e)

@meta-codesync

meta-codesync Bot commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

@chinnadhurai has exported this pull request. If you are a Meta employee, you can view the originating Diff in D121895059.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Summary:

Preserve zero-centered gamma semantics for transformer block and output RMSNorms in both ExecuTorch and rlformers ET paths while leaving Q/K norms unchanged. Preserve output_norm_gain_center_type so center-zero output weights are not shifted.

Authored with assistance from Codex.

Differential Revision: D121895059
@meta-codesync meta-codesync Bot changed the title Fix zero-centered gamma parity for ET RMSNorm Fix zero-centered gamma parity for ET RMSNorm (#23193) Sep 28, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants