Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing a
collections.namedtuplefrom another module can make document symbols return an empty result. Jedi reports the imported class in the current document, but its generated members havemodule_path=None, so processing those members raisesTypeErrorinPath(None)before the remaining local symbols are returned.Skip definitions without a source path before comparing paths. This preserves the imported class and the rest of the document's symbols while respecting
include_import_symbols. The regression uses real files and Jedi, covering both values ofall_scopesandinclude_import_symbols.Fixes #635.
Validation on Python 3.11.16 / Linux (WSL), with Jedi 0.20.0:
CI=true pytest -q test/, including the separate/tmp/pyenvenvironment required by the CI workflow: 206 passed, 9 skipped.pylspandtest.This contribution was prepared with OpenAI Codex. The behavior and validation above were reproduced locally.