Clamp Flake8 diagnostic columns to nonnegative positions - #726
Open
ryanchou1994 wants to merge 1 commit into
Open
ryanchou1994 wants to merge 1 commit into
ryanchou1994 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some Flake8 plugins report column 0 for diagnostics without a precise column. Subtracting one for LSP's zero-based positions then produces
character: -1, which clients cannot use. Clamp the converted column to zero while keeping normal positive columns unchanged.Fixes #615.
Added regression tests for column 0 on a comment and a blank line, plus column 1 and 5 controls. The two column-zero cases fail on the unchanged base. The reported output was also reproduced with Flake8 7.1.1 and flake8-annotations 3.1.1.
Validation: the Flake8 test file passes all 12 tests on macOS/Python 3.13 and Linux/Python 3.11; Ruff check and format pass. Full-suite attempts are not green:
test_missing_messagehas a teardown error, and two autoimport tests can time out during initialization. The teardown error also occurs on the unchanged base; both initialization timeouts were separately reproduced with the unchanged source in a fresh Linux container.