Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README still shows
naturaldelta(timedelta(seconds=1001))returning16 minutes, although #272 changednaturaldeltato round to the nearest unit. Update the expected output to17 minutesso the example matches the current implementation and documented behavior.Changes proposed in this pull request:
Validation: statically checked the minute branch (
round(delta.seconds / 60)), the rounding docstring, the existing 1m29s/1m30s/1m59s test cases, and the changes in #272. Independently checked the arithmetic for 1001 seconds. I did not run Humanize, its test suite, linting, or the documentation build.Prepared with assistance from OpenAI Codex.