parse_decimal: reject underscore grouping with strict=True - #1355
Open
glaziermag wants to merge 1 commit into
Open
glaziermag wants to merge 1 commit into
glaziermag wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_decimal('1_000', locale='en_US', strict=True)currently returnsDecimal('1000'), although strict mode promises to reject irregularly formatted numbers. The strict-validation branch only runs when the locale's grouping separator is present, soDecimal's underscore syntax bypasses it.Run against the current default branch:
The documented strict-mode guarantee requires an exception for irregular formatting.
This change sends underscore-containing input through the existing strict validation. Regression tests cover
en_USandde, including acceptance of valid grouped and ungrouped input and preservation of permissive parsing.Validation: clean baseline reproduced twice; full local suite on Python 3.12: 7,833 passed, 7 skipped, 2 xfailed. Ruff and
git diff --checkpass. The new regression cases also pass after the final lint adjustment.Prepared with AI assistance.