Accept C and POSIX in Locale.parse - #1340
Merged
Merged
Conversation
default_locale already maps those to en_US_POSIX. parse() did not, so a C locale from the environment raised UnknownLocaleError.
akx
requested changes
Sep 18, 2026
|
|
||
| # C/POSIX is not a CLDR language. Same mapping default_locale uses. | ||
| posix_stem = identifier.split(".")[0].split("@")[0] | ||
| posix_stem = posix_stem.replace("-", "_") |
Member
There was a problem hiding this comment.
Why is this replace necessary? "C" and "POSIX" don't include dashes or underscores.
| raise TypeError(f"Unexpected value for identifier: {identifier!r}") | ||
|
|
||
| # C/POSIX is not a CLDR language. Same mapping default_locale uses. | ||
| posix_stem = identifier.split(".")[0].split("@")[0] |
Member
There was a problem hiding this comment.
What's the @ splitting for? The test case doesn't seem to exercise it, and in any case a @ modifier would be in the postfix already split out by .split(".").
Additionally, please use .partition(".") in cases like this for performance.
C and POSIX never include a dash or @ modifier on the language stem, so the extra replace and split were noise.
Contributor
Author
|
Dropped the dash replace and the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1340 +/- ##
=======================================
Coverage 93.37% 93.37%
=======================================
Files 27 27
Lines 4919 4922 +3
=======================================
+ Hits 4593 4596 +3
Misses 326 326
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1236.
default_locale()mapsC,POSIX, andC.UTF-8toen_US_POSIX.Locale.parse()did not, soLocale.parse("C")raisedUnknownLocaleError: unknown locale 'c'. That is the frame in the report.parse()now applies the same mapping (case-insensitive, optional encoding suffix) beforeparse_locale.en_US_POSIXwith a POSIX variant is unchanged.