Repository navigation
feat(footer): use @profullstack/footer - #236
Merged
Merged
Conversation
Replaces the hand-written footer / ring nav with the shared @profullstack/footer, rendered on the server so the ring verifier sees it and a package release updates the footer without a redeploy. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return ( | ||
| <> | ||
| <div id="app" dangerouslySetInnerHTML={{ __html: renderPageMarkup(slug?.[0] ? `/${slug[0]}` : "/") }} /> | ||
| <div id="app" dangerouslySetInnerHTML={{ __html: renderPageMarkup(slug?.[0] ? `/${slug[0]}` : "/", footer) }} /> |
ThreatCrush Security Scan27 finding(s) HIGH/CRITICAL: 3 | MEDIUM: 12 | LOW: 12
Snippets are redacted; ThreatCrush never prints matched credential material. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces both hand-written footers with
@profullstack/footer("latest"), server-rendered:lib/site-footer.ts: the footer options (site https://logicsrc.com/, links Specs / Docs / RSS / llms.txt / Terms / Privacy) andsiteFooterHtml().SiteShell(standalone routes): the inline<footer>with the link row, copyright and ring nav becomes<Footer {...SITE_FOOTER} />from@profullstack/footer/react, in the same muted color.[[...slug]], the legacy markup string): the page awaitssiteFooterHtml()and passes it torenderPageMarkup(path, footer), replacing the ring-only footer added in feat(webring): Random link in the Profullstack ring footer #234. So the homepage now has the full footer too.data-pfs-footerplus previous / next / random with from=https://logicsrc.com/.Locally: logicsrc-web contract suite passes (26). Two other contract files fail locally only because the workspace packages are not built here (CI builds first). bun.lock: only the footer entries added (
bun install --frozen-lockfileaccepts it).🤖 Generated with Claude Code