Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Root cause
Mandatory custom fields were enforced unconditionally, even for items created without any human filling a form (tickets generated by the Mail Collector) Since there is no way to fill a mandatory custom field from an incoming email, item creation was silently rejected with "Some mandatory fields are empty".
Fix
Mandatory field enforcement in
PluginFieldsContainer::validateValues()is nowskipped when any of the following applies:
isCommandLine())Session::isCron())(
_auto_import), set byMailCollector::buildTicket()and by recurringtickets, this covers the "Collect now" button too, which is a plain web
request (neither CLI nor cron), so it wasn't covered by the first two checks
alone.
Steps to reproduce
Ticketwith a mandatory custom field and nodefault value.
empty"), even though there is no way for the sender to fill that field.
After the fix: the ticket is created normally.