Repository navigation
Decode percent-encoded URL credentials before authentication - #225
Draft
Kayvan-Zahiri wants to merge 1 commit into
Draft
Kayvan-Zahiri wants to merge 1 commit into
Kayvan-Zahiri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
URL-based configuration reads username and password directly from the URL object, whose properties remain percent-encoded. This sends encoded characters in the Basic authentication header and rejects otherwise valid credentials containing characters such as @, /, spaces, or percent signs.
Decode both URL userinfo fields once before storing them. Three request-level regressions assert the exact Basic header and exposed configuration. A password containing literal
%2Fverifies that it is not decoded a second time.Validation: all three regressions fail before the fix; all45 tests pass afterward.
npm testbuilds the ESM and CommonJS variants before exercising the real driver with Undici's network-disabled MockAgent.npm run lintandgit diff --checkpass. Tested on Node24.1.0 withnpm cilockfile dependencies; the Node22/24 CI matrix and hosted database authentication were not run. All credentials in tests are synthetic.