Repository navigation
Replace NONE with a notes button next to posts and on profiles - #8
Merged
Merged
Conversation
The SEE NOTES line now shows only while a member has a current reason. Staff get a Moderator notes button with the post buttons and a link with the profile's user statistics, for every member; without a current reason they open the Give a reason form. phpBB 4.0 draws post button icons with Icon(), so the button has a template per branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…llery Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces "SEE NOTES: NONE" with a notes button, after Kailey's feedback that members without a reason should show nothing, as phpBB.com's staff field does.
What changes
Icon()Twig function, which phpBB 3.3 cannot compile, so the button has one template per branch, picked at runtime.docs/update/2026-11-08/).Testing
Claude ran:
php -lon PHP 7.4 and 8.4, and the template accessibility check.Investigated and written by Claude on behalf of William Jacoby (bonelifer).