Skip to content

Replace NONE with a notes button next to posts and on profiles - #8

Merged
bonelifer merged 2 commits into
mainfrom
notes-button
Nov 8, 2026
Merged

bonelifer merged 2 commits into
mainfrom
notes-button

Conversation

@bonelifer

Copy link
Copy Markdown
Contributor

Replaces "SEE NOTES: NONE" with a notes button, after Kailey's feedback that members without a reason should show nothing, as phpBB.com's staff field does.

What changes

  • The SEE NOTES line shows only while a member has a current reason. Members without one show nothing extra.
  • Staff with the See Notes view permission get a Moderator notes button with the post buttons, beside phpBB's Warn button, and a Moderator notes link with the profile's user statistics. Both are there for every member, so nothing appears or disappears with the notes. Without a current reason, staff who may give one land on the Give a reason form.
  • phpBB 4.0 draws post button icons with its Icon() Twig function, which phpBB 3.3 cannot compile, so the button has one template per branch, picked at runtime.
  • Docs, screenshots and a dated gallery for the forum update post (docs/update/2026-11-08/).

Testing

Claude ran:

  • PHPUnit against phpBB 3.3.x and master.
  • EPV against 3.3.x and master, the code sniffer with both rulesets, php -l on PHP 7.4 and 8.4, and the template accessibility check.
  • The feature check (updated in phpbbmodders/phpbb-release-tools) on phpBB 3.3 and 4.0 with SQLite, MySQL, MariaDB, PostgreSQL and MSSQL.
  • A browser check on phpBB 3.3 and 4.0 seed boards: the button and profile link render, open the Give a reason form for a member without a reason, and cause no JavaScript errors.

Investigated and written by Claude on behalf of William Jacoby (bonelifer).

bonelifer and others added 2 commits November 8, 2026 11:45
The SEE NOTES line now shows only while a member has a current
reason. Staff get a Moderator notes button with the post buttons and a
link with the profile's user statistics, for every member; without a
current reason they open the Give a reason form. phpBB 4.0 draws post
button icons with Icon(), so the button has a template per branch.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…llery

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bonelifer
bonelifer merged commit efd8734 into main Nov 8, 2026
57 checks passed
@bonelifer
bonelifer deleted the notes-button branch November 8, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant