Skip to content

Fix enabling the extension on a fresh board - #6

Merged
bonelifer merged 1 commit into
mainfrom
fix-fresh-install
Sep 28, 2026
Merged

bonelifer merged 1 commit into
mainfrom
fix-fresh-install

Conversation

@bonelifer

Copy link
Copy Markdown
Contributor

Summary

  • Enabling the extension always failed on a fresh board with "You have requested a non-existent service phpbbmodders.documentation.permission_sync". The install migration asked the container for this extension's own service, but during the first enable the container doesn't include the extension's services yet (it only counts as enabled once its migrations finish).
  • When the service isn't available, the migration now sets a phpbbmodders_documentation_sync_pending flag instead, and the event listener runs the permission sync on the next request. set_atomic() claims the flag, so the sync runs only once. Boards that already ran the migration are unaffected.

Test plan

Claude tested on a fresh phpBB 3.3.19 board (SQLite, PHP 8.4) with a small docs build in place:

  • main: enabling fails with the error above.
  • This branch:
    • enabling succeeds and leaves the sync pending
    • the first page load runs it and clears the flag
    • the language and section permissions are created
    • a guest can read the docs home and a section page
    • board pages and the ACP module load with no PHP errors

Investigated and written by Claude on behalf of William Jacoby (bonelifer).

The install migration asked the container for this extension's own
permission_sync service, but during the first enable the container
doesn't include the extension's services yet, so enabling always failed
with "non-existent service". When the service isn't available, the
migration now sets a sync-pending flag instead, and the event listener
runs the sync on the next request. Boards that already ran the
migration are unaffected.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bonelifer
bonelifer merged commit 4e214af into main Sep 28, 2026
7 checks passed
@bonelifer
bonelifer deleted the fix-fresh-install branch September 28, 2026 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant