Fix enabling the extension on a fresh board - #6
Merged
Merged
Conversation
The install migration asked the container for this extension's own permission_sync service, but during the first enable the container doesn't include the extension's services yet, so enabling always failed with "non-existent service". When the service isn't available, the migration now sets a sync-pending flag instead, and the event listener runs the sync on the next request. Boards that already ran the migration are unaffected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
phpbbmodders.documentation.permission_sync". The install migration asked the container for this extension's own service, but during the first enable the container doesn't include the extension's services yet (it only counts as enabled once its migrations finish).phpbbmodders_documentation_sync_pendingflag instead, and the event listener runs the permission sync on the next request.set_atomic()claims the flag, so the sync runs only once. Boards that already ran the migration are unaffected.Test plan
Claude tested on a fresh phpBB 3.3.19 board (SQLite, PHP 8.4) with a small docs build in place:
main: enabling fails with the error above.Investigated and written by Claude on behalf of William Jacoby (bonelifer).