PDO: Make PDO_ATTR_FETCH_TABLE_NAMES generic in PDO - #23872
Draft
NattyNarwhal wants to merge 9 commits into
Draft
NattyNarwhal wants to merge 9 commits into
NattyNarwhal wants to merge 9 commits into
Conversation
Required to make PDO_ATTR_FETCH_TABLE_NAMES generic across drivers.
Note I was not able to get a table name from the Db2i driver at least.
Previously drivers had to implement this attribute themselves, and only MySQL and Firebird did so, in spite of support being generic. Remove driver-specific logic for this as well (Firebird's was harrowing).
NattyNarwhal
force-pushed
the
fetch-table-name-generic
branch
from
September 24, 2026 00:38
3b0b122 to
0212ed8
Compare
Now that we need this for ATTR_FETCH_TABLE_NAMES, we might as well make this part of the generic PDO method and not driver specific ones.
NattyNarwhal
force-pushed
the
fetch-table-name-generic
branch
from
September 24, 2026 06:08
0212ed8 to
cd85c8f
Compare
In addition to the MySQL specific one.
NattyNarwhal
force-pushed
the
fetch-table-name-generic
branch
from
September 24, 2026 06:59
cd85c8f to
55c246f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than having to be re-implemented by each driver. Also makes "table" in getColumnMeta generic as well due to this refactor.
Some notes:
SQLColAttributewithSQL_DESC_TABLE_NAMEto work with the Db2i driver; I ahve not tested the SQLite ODBC or SQL Server drivers.