Repository navigation
Conversation
lacatoire
force-pushed
the
submit/fpm-changes-85
branch
2 times, most recently
from
September 10, 2026 14:34
e3e24c5 to
812a99d
Compare
jordikroon
reviewed
Sep 30, 2026
Member
Author
|
Addressed the ProxyPass remark, merging this week unless someone objects. |
jordikroon
reviewed
Oct 29, 2026
| <!-- <link linkend="ini.fastcgi.script_path_encoded"-->fastcgi.script_path_encoded<!-- </link> --> | ||
| INI setting to prevent this new behavior. | ||
| FPM with httpd | ||
| <link xlink:href="https://httpd.apache.org/docs/current/mod/mod_proxy.html#proxypass"><literal>ProxyPass</literal></link> |
Member
There was a problem hiding this comment.
Can you add this as entity? Would it make more sense to add &url.apache.proxy;#proxypass or should we narrow it down to &url.apache.proxy.proxypass;?
jordikroon
reviewed
Oct 29, 2026
| <link xlink:href="https://httpd.apache.org/docs/current/mod/mod_proxy.html#proxypass"><literal>ProxyPass</literal></link> | ||
| can optionally decode the full script path as of PHP 8.5.0. | ||
| The new <link linkend="ini.fastcgi.script-path-encoded">fastcgi.script_path_encoded</link> | ||
| INI setting controls this behavior; it defaults to <literal>1</literal> to preserve |
jordikroon
reviewed
Oct 29, 2026
| When enabled (<literal>1</literal>, the default as of PHP 8.5.0), | ||
| FPM does not URL-decode the <literal>SCRIPT_FILENAME</literal> sent | ||
| by httpd | ||
| <link xlink:href="https://httpd.apache.org/docs/current/mod/mod_proxy.html#proxypass"><literal>ProxyPass</literal></link>, |
Member
There was a problem hiding this comment.
We can then use the same entity here.
lacatoire
force-pushed
the
submit/fpm-changes-85
branch
from
October 29, 2026 17:34
b229fa9 to
f0c4aa7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
install/fpm/configuration.xml: documentfastcgi.script_path_encodedINI setting andaccess.logrespectinglog_limitas of PHP 8.5.0 (PHP 8.5 Documentation Tracker)appendices/migration85/other-changes.xml: fix commented-out link tofastcgi.script_path_encoded(PHP 8.5 Documentation Tracker)