Repository navigation
Support PHP 8.4 and 8.5 - #89
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running the published phar on PHP 8.5 prints deprecations (
E_STRICTin bundled composer,curl_close(), implicitly nullable params in bundled symfony/string). This fixes them.Code
curl_close()(deprecated in 8.5) and made implicitly nullable params explicit insrc/andtest/. Also removedsetAccessible()(deprecated in 8.5) from a test.mnapoli/silly-php-di: it has no release without the nullable-param deprecation and callsbuildDevContainer(), which php-di 7 removed.Applicationnow extendsSilly\Applicationand callsuseContainer()itself.InstallResult,RecordingOutput).Dependencies
php^8.2(was^7.2|^8.0), withconfig.platform.phpset to 8.2.0 so the lock and the phar resolve for 8.2+.composer/composer^2.10(locked 2.10.3). Composer up to 2.9.x throws "Your github oauth token for github.com contains invalid characters" for GitHub's newer token format (for exampleGITHUB_TOKEN/COMPOSER_AUTHin Actions). 2.10.0 removed that check, so 2.10 is the floor,symfony/*^6.4 | ^7.0(locked 7.4),php-di/php-di^7.0,php-http/guzzle7-adapter^1.1.padraic/phar-updater(abandoned, needs PHP 7) with the drop-in forklaravel-zero/phar-updater^1.4. It uses the sameHumbug\SelfUpdatenamespace.VerifyInstallnow says PHP 8.2 is the minimum.Please review: advisory blocking. Composer 2.9+ refuses to resolve packages that have security advisories. Every 2.8.x release has advisories too, so staying on 2.8 isn't an option. Because of this, installing a tagged workshop (
install learnyouphp, which resolves 0.6.1 → league/commonmark 1.x) failed.ComposerInstallernow setspolicy.advisories.block = falsefor workshop installs. That matches what the current phar does. Advisories are still reported. If you'd rather keep blocking, drop that line, but tagged workshops will stop installing until their dependencies are updated.Phar build
box.phar compile).vendor/symfony/console/Resourcesis added to the phar because Symfony 7's completion command reads it at runtime.bin/deploy.sh, which pushes togh-pages) now runs on the 8.4 job instead of 7.2. Coverage moved to 8.4 as well.php:8-cli.CI: matrix is now 8.2–8.5, the job has
timeout-minutes: 15, phpunit runs with--stop-on-error, and checkout is v4.Republish needed: yes. https://php-school.github.io/workshop-manager/workshop-manager.phar is still the old build. Merging to
masterrunsbin/deploy.shand pushes a rebuilt phar togh-pages. Nothing has been published from this branch.Tested locally
error_reporting=-1,install learnyouphp,uninstall,install learnyouphp masterandinstalledall work with no deprecation output. The phar also runs clean on 8.2.