Repository navigation
fix(downloader): rank universal macOS builds and x86-64 microarchitecture levels - #167
Merged
Merged
Conversation
Names like `darwin-universal` or `macOS_all` carry no arch token, so a strict selection dropped them and a gradual one ranked them below `darwin-amd64` on Apple Silicon, although they run natively on both Mac architectures; some tools ship only such a build for macOS. `all` and `universal` count only next to the macOS token, where they are part of the platform rather than an extra token of the name. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
…lower In `amd64_v3` the level was dropped as a version token, so `_v1` and `_v3` builds tied and the release order decided: a v3 build could be picked on a CPU without AVX2. The CPU is not checked, so a higher level is ranked after the plain or v1 build rather than removed, and stays selectable when the release has nothing else for the host. `x86-64` is read as the x86-64 architecture too, so `x86-64-v3` builds have an arch. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 What was changed
darwin-universal,tigerbeetle-universal-macos,macOS_all,universal2) counts as built for the host architecture on both Intel and Apple Silicon: a strict selection keeps it and it ranks above an x86-64 build run through Rosetta.universalandallcount only right next todarwin/macos; on other OSes nothing changes.amd64_v2,amd64_v3,x86_64_v3,x86-64-v4) ranks after the plain or_v1build of the same arch. The CPU is not checked, so such a build is never removed and is still picked when it is the only one for the host. The newlevelrank sits right afterarchin the-vvvoutput.x86-64is now read as the x86-64 architecture, sox86-64-v3names have an arch.Item 1 of the issue (platform words inside a tool name, like
android-tools-linux-x64.zip) is left out of this PR.Checklist
Documentation
skills/dload-fetch-tool/references/registry-entry.mdandtroubleshooting.mddescribe the universal build, the level rank and thex86-64token. The READMEs do not describe asset ranking, so they are unchanged.