Repository navigation
fix(downloader): remove the partial file of a failed download - #166
Merged
Merged
Conversation
The cleanup unlinked `SplFileObject::getPath()`, which is the temp directory, so every release DLoad fell back from left its asset file behind. The handle is dropped before the delete so the name is freed at once on Windows filesystems without POSIX delete semantics. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 What was changed
<tempDir>/<asset name>file; before, the cleanup unlinked the temp directory (SplFileObject::getPath()) and silently failed, leaving one file per release DLoad fell back from.Checklist
Review notes
unlink()of a file still open throughSplFileObjectalready succeeds and the name disappears at once, so the handle release is a safeguard for filesystems without POSIX delete semantics rather than the fix itself.Installation::moveToDestination(), archive detection by extension), so a fix needs a per-download subdirectory and its cleanup in the installer — left for a separate change.