Repository navigation
fix(version): read a pre-release before a feature as a range bound - #162
Merged
Merged
Conversation
A constraint like `^3.5.0-beta.1-feature` took the whole `beta.1-feature` as the feature, while a tag keeps only `feature` as its suffix, so the constraint matched nothing. The pre-release now bounds the range and sets the minimum stability, as it does without a feature, and the rest filters by the feature. Closes #151 Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
github-actions
Bot
added
bug
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 What was changed
^3.5.0-beta.1-feature,~…,>=…, a glued^3.5.0-rc1-feature, with or without@stability— matched nothing; it now reads like the same range without the feature plus the feature filter: the pre-release is the lower bound and the minimum stability, and the tag must contain the feature.3.5.0-beta.1-featurealready matched only its own tag since feat(version): match version constraints with DLoad's own ordering #155; it is covered by tests now.^2.0-beta-feature) is a bound too, as in^2.0-beta@alpha: with@alpha,2.0.0-alpha.1-featurestays below the bound, while2.1.0-alpha.1-featurematches.Checklist