Repository navigation
Rebind PDO statement parameters on every execute - #234
Open
simon-mundy wants to merge 3 commits into
Open
simon-mundy wants to merge 3 commits into
simon-mundy wants to merge 3 commits into
Conversation
bindParametersFromContainer() returned early once parameters had been bound, so re-executing a prepared statement with new values (via an array, a replacement ParameterContainer, or a mutated container) ran again with the first values. Bind from the current container on every execute instead.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Pdo\Statement::bindParametersFromContainer()returned early once$parametersBoundwas set, so re-executing a prepared statement with new values silently ran with the first values:The same happened when passing a replacement
ParameterContaineror mutating the existing container between executes. PDO'sbindParam()binds by reference to a local copy of the container's values, so later container changes never reached the statement.Fix
Remove the early return so parameters are bound from the current container on every
execute(). The$parametersBoundproperty is left in place for subclass compatibility.Tests
Pdo\Statementstays at 100% line coverage.mago format --check,mago lintandmago analyzeare clean; one lint-baseline entry forStatement.php(kan-defect) no longer applies and has been dropped.