Repository navigation
fix: treat a false row from PDO as no record - #10
Merged
Merged
Conversation
Signed-off-by: Joey Smith <jsmith@webinertia.net>
Signed-off-by: Joey Smith <jsmith@webinertia.net>
Signed-off-by: Joey Smith <jsmith@webinertia.net>
Signed-off-by: Joey Smith <jsmith@webinertia.net>
This was referenced Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AbstractDbValidator::query()returned$statement->execute()?->current(). The PDO result'scurrent()returnsfalsewhen there are no rows, andNoRecordExiststests!== null, so it reported "A record matching the input was found" for a value that does not exist (RecordExistsuses a falsy check and was unaffected).query()now returnsnullforfalse, matching its documented contract. Regression test added: a result whosecurrent()isfalseis valid forNoRecordExists. It fails without the source change (verified).Found by running
NoRecordExistsagainst a real MySQL database: an existing value returned the row, a nonexistent one returnedfalse.composer test: 35 tests, 50 assertions, OK.