Skip to content

Whitelist gliard.com & pay.gliard.com (false positive) - #1868

Open
Adamkucera2 wants to merge 1 commit into
phantom:masterfrom
Adamkucera2:whitelist-gliard
Open

Adamkucera2 wants to merge 1 commit into
phantom:masterfrom
Adamkucera2:whitelist-gliard

Conversation

@Adamkucera2

@Adamkucera2 Adamkucera2 commented Oct 19, 2026 •

Copy link
Copy Markdown

Domains to whitelist

  • gliard.com
  • pay.gliard.com

Why this domain should be whitelisted

Gliard is a non-custodial peer-to-peer Web3 payment and swap bridge built for Discord communities.

  • Non-Custodial & Direct: Transactions are strictly peer-to-peer (P2P). No intermediate custody, smart contract deposits, or bot escrow balances.
  • Solana Actions & Solana Pay Compliant: We implement the official Solana Actions & Solana Pay specification with root domain mapping (https://pay.gliard.com/actions.json) and Action endpoints (https://pay.gliard.com/api/solana-pay/*).
  • Standard Protocol Settlement: Transactions settle directly from payer to payee with an atomic, transparent 0.5% protocol fee instruction.
  • Cross-Wallet Interoperability: Already tested and operating cleanly across Backpack and Solflare wallets.

Currently, scanning our standard Solana Pay / Actions QR code on Phantom Mobile triggers a false positive "Request blocked / This dApp could be malicious" heuristic warning due to domain newness.

Verification

Summary by CodeRabbit

  • Updates
    • gliard.com and pay.gliard.com are now included among the supported domains.
    • nftplus.io remains supported.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 95266a1a-491a-4c80-90ea-404423f5fe30
📥 Commits

Reviewing files that changed from the base of the PR and between 5030186 and e21eee5.

📒 Files selected for processing: 1
  • whitelist.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The whitelist retains nftplus.io and adds gliard.com and pay.gliard.com.

Changes: Whitelist updates

Layer / File(s) Summary
Update whitelist entries
whitelist.yaml
The whitelist retains nftplus.io and adds gliard.com and pay.gliard.com.

Suggested reviewers: hanahiroaze

Priority: ⬇️ Low

Change: Bug fix

Merge Risk: ⚪ Minimal · up to e21ee

The requested domains are added. Whether they clear the reported Phantom Mobile warning remains unconfirmed, but no actionable merge-blocking issue is established.

### Architecture Summary

Architecture risk: 🔵 Low · up to e21ee

The change affects 1 system.

Changed systems: whitelist.yaml

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — whitelist.yaml (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in whitelist.yaml: The nftplus.io whitelist entry remains, and entries for gliard.com and pay.gliard.com are added.
Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: adding gliard.com and pay.gliard.com to the whitelist because of a reported false positive.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

⚠️ This pull request has been flagged as potential spam (promotional) by CodeRabbit slop detection and should be reviewed carefully.

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant