Repository navigation
[FEATURE] UI Customization. Define layers in every component so consumers do not have to initialize them - #392
Merged
Conversation
…mers do not have to initialize them Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
Contributor
|
Awesome. The /lgtm |
zhuje
added a commit
that referenced
this pull request
Oct 27, 2026
Declare `box-sizing: border-box` on `.ps-Grid` and `.ps-GridItem`, matching Box, Stack, Checkbox, Switch and Table, and flip the test to assert it is present. The design-tokens reset (`@layer perses.reset`) does set border-box on every element, but `@perses-dev/components/next/css` deliberately does not import that reset. A consumer who loads only the components CSS therefore gets content-box, and `<Grid width="100%" px="md">` overflows its container while the same props on Box and Stack do not. Also add the `@perses-dev/design-tokens/css/layers` import prelude that every primitive stylesheet must start with since #392 (layers.test.ts). Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com>
zhuje
added a commit
that referenced
this pull request
Oct 28, 2026
Declare `box-sizing: border-box` on `.ps-Grid` and `.ps-GridItem`, matching Box, Stack, Checkbox, Switch and Table, and flip the test to assert it is present. The design-tokens reset (`@layer perses.reset`) does set border-box on every element, but `@perses-dev/components/next/css` deliberately does not import that reset. A consumer who loads only the components CSS therefore gets content-box, and `<Grid width="100%" px="md">` overflows its container while the same props on Box and Stack do not. Also add the `@perses-dev/design-tokens/css/layers` import prelude that every primitive stylesheet must start with since #392 (layers.test.ts). Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com>
zhuje
pushed a commit
that referenced
this pull request
Oct 28, 2026
…mers do not have to initialize them (#392) Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
zhuje
added a commit
that referenced
this pull request
Oct 28, 2026
Declare `box-sizing: border-box` on `.ps-Grid` and `.ps-GridItem`, matching Box, Stack, Checkbox, Switch and Table, and flip the test to assert it is present. The design-tokens reset (`@layer perses.reset`) does set border-box on every element, but `@perses-dev/components/next/css` deliberately does not import that reset. A consumer who loads only the components CSS therefore gets content-box, and `<Grid width="100%" px="md">` overflows its container while the same props on Box and Stack do not. Also add the `@perses-dev/design-tokens/css/layers` import prelude that every primitive stylesheet must start with since #392 (layers.test.ts). Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.