Repository navigation
Conversation
swatikumar-pplx
approved these changes
Oct 19, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
makeApiRequestbuilds the request URL as${PERPLEXITY_BASE_URL}/${endpoint}, so a query string inPERPLEXITY_BASE_URLswallows the endpoint path:https://proxy.example.com/api/?key=xbecomeshttps://proxy.example.com/api/?key=x/v1/agent.This parses the base URL and appends the endpoint to its pathname, which keeps the base query intact and avoids a double slash when the base URL ends in
/. Base URLs without a query or trailing slash produce the same URL as before.Same issue as perplexityai/perplexity-py#139.
Validation: new test fails before the change and passes after.
tsc --noEmitpasses, andvitest runpasses apart fromproxyAwareFetch > should NOT use native fetch when proxy is configured, which also times out onmainin my environment.