Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by consolidated postal geocoding PR #124. This PR's head commit is retained in the combined branch. Combined CI passes on Node.js 24/26 and static checks.
Summary
FIN currently returns no coordinates. Add 3,018 unique five-digit postal-area points from Statistics Finland's 2026 Paavo layer, retrieved 2026-11-04, under CC BY 4.0 with attribution.
Points are area-weighted geometric centroids in the WGS84 longitude/latitude plane, with holes subtracted and MultiPolygon parts included. This is approximate area-level geocoding, not address or site accuracy. Special recipient and PO box codes without polygons remain unsupported. Åland is included. Large northern/rural areas can have errors of many kilometres; centroids can lie outside the area or in water.
Add a standard-library Python generator with assert checks, country-focused offline tests, and source/licence/method documentation in
docs/geocode-FIN.md. Preserve all other countries, existing normalization, string output, and unknown-code behavior. Shared-file overlap with other country PRs is limited tolib/geocode.js's allowlist.Evidence
undefined.After: all 3,018 codes resolve; pinned official-layer examples cover Helsinki, Salla, Utsjoki, Mariehamn and Nauvo.
npm test: 98 passed.npm run lint,npm run format:check,npm run validate:data: passed. Data validation retains two existing AUT/BEL warnings.Merge Danger
Door: two-way
Static additive data and one allowlist entry; no publish, deployment or merge performed.
Blast Radius: FIN
Callers now receive area coordinates for supported FIN codes. Distance accuracy is limited by postal-area size and the centroid method. No independent address-level accuracy check was performed.