Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by consolidated postal geocoding PR #124. This PR's head commit is retained in the combined branch. Combined CI passes on Node.js 24/26 and static checks.
Summary
Return-location distance analysis needs consistent NLD postal lookup. Refresh the GeoNames prefix points and accept compact full postcodes.
GeoNames NL.zip, retrieved 2026-11-04, is CC BY 4.0. Convert 4,334 source rows into 4,086 unique prefix records using the mean of distinct coordinate pairs. Record attribution, snapshot hashes, generation method, coverage limits, and PDOK sample checks in docs/geocode-NLD.md. Coordinates remain strings. This provides approximate four-digit prefix locations, without an accuracy bound or complete national coverage claim.
Evidence
1012ABmisses; repeated prefixes select the first locality.npm test: 99 passed.npm run lint,npm run format:check,npm run validate:data: passed. Data validation has two existing AUT/BEL warnings.Merge Danger
Door: two-way
Blast Radius: NLD
NLD coordinates change with the source refresh and representative-point method. Malformed NLD inputs now miss. Two-letter suffixes select the four-digit prefix; these points cannot locate a building or assess fraud. Caribbean Netherlands coverage is not established. Other countries retain their normalization and allowlist entries. The minimal lib/geocode.js edit can overlap with concurrent country PRs. No merge or deployment requested.