Repository navigation
OD-2292.1 - reformatted to use parameterized queries in steps 03 and 04 - #97
Open
thatgirlginger wants to merge 1 commit into
Open
thatgirlginger wants to merge 1 commit into
thatgirlginger wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to this JIRA ticket here about swapping string-formatted queries for parameterized ones whenever possible: https://otwarchive.atlassian.net/browse/OD-2292
this eliminates the need for string/html escaping in the majority of cases, speeds up on processing quite a bit, and cuts down on resource usage (my CPU temps were HEAVILY spiking while doing processing before i changed these, and now they're staying pretty normal).
the changes in this PR are mostly for steps dealing with tag extraction and remapping - the later stages (especially those making the final tables) are a little bit more difficult due to the ways that their functions write the queries. i will evaluate and make those changes soon