Repository navigation
feat(schema): accept the number pool allocation_scope in the generated schema models - #1402
Merged
ajtmccarty merged 4 commits intoOct 8, 2026
Merged
Conversation
Deploying infrahub-sdk-python with
|
| Latest commit: |
fdd14b8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://87b57488.infrahub-sdk-python.pages.dev |
| Branch Preview URL: | https://ifc-3334-allocation-scope.infrahub-sdk-python.pages.dev |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## pmi-number-pool-range-protocols #1402 +/- ##
================================================================
Coverage 86.82% 86.82%
================================================================
Files 152 152
Lines 14759 14775 +16
Branches 1982 1982
================================================================
+ Hits 12815 12829 +14
- Misses 1381 1382 +1
- Partials 563 564 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
polmichel
added this pull request to stack #1403
October 7, 2026 08:10
polmichel
removed this pull request from stack #1403
October 7, 2026 08:11
polmichel
added this pull request to stack #1404
October 7, 2026 08:11
polmichel
approved these changes
Oct 7, 2026
ajtmccarty
force-pushed
the
ifc-3334-allocation-scope
branch
from
October 7, 2026 17:18
d013309 to
d0c5d0c
Compare
ajtmccarty
removed this pull request from stack #1404
October 8, 2026 15:31
NumberPool attribute parameters carry `ranges`, a list of start/end ranges with an optional weight, next to the `start_range`/`end_range` shorthand. The shorthand is optional and deprecated, so an attribute declared without any range no longer receives a default range. Bookkeeping fields on a range are reported as read-only like on every other value model. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The generated descriptions of start_range and end_range now say that a missing start defaults to 1 and a missing end to the largest supported number when only the other bound is set. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d schema models Regenerate the schema models and protocols for Infrahub's new `allocation_scope` field: `NumberPoolParametersRead`/`Write` gain `allocation_scope: list[str] | None`, and `CoreNumberPool` gains the matching optional List attribute. Without it, a schema read from Infrahub and loaded back is rejected because the field is unknown. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
ajtmccarty
force-pushed
the
ifc-3334-allocation-scope
branch
from
October 8, 2026 15:32
d0c5d0c to
fdd14b8
Compare
ajtmccarty
added this pull request to stack #1411
October 8, 2026 15:48
2 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
regenerated schema for new
allocation_scopefield onCoreNumberPoolandNumberPoolParameters. goes with opsmill/infrahub#10917targets pmi-number-pool-range-protocols b/c the infrahub-side
feature-number-pools-1.12branch needs the changes on that SDK branch, but probably worth making a matchingfeature-number-pools-1.12branch on the SDK too for now