Repository navigation
Conversation
somiaj
force-pushed
the
user-detail-unassign-confirm
branch
from
October 6, 2026 15:17
3da69ef to
29568ef
Compare
Update the displayed information on the user detail page.
+ State how many sets a user is assigned to out of the total number.
+ Change the "edit class list data" link to a button.
+ Only show the "Assign All sets to Current User" button if the
user isn't assigned to all sets, and state the user's name
instead of "Current User".
+ Remove all the warnings from the page. Add a statement that
unchecking the "Assigned" checkbox will unassign a set and
cannot be undone.
+ Call the table "Available Sets", as it contains more sets
than the ones assigned to the user.
Add a confirmation modal that appears whenever a set is unchecked
to require confirmation. This also adds a hidden field so the
unassign on the server side will only unassign if that hidden
field had been updated to true.
Add a check to see if any of the dates were actually changed, and
only update the database entry in the case a change was made to
avoid unneeded database calls.
There was some logic which I believe was trying to allow a set date
to be "0", but it wasn't working, `param('x') && param('x') ne ''`
was being used, which I think was meant to allow "0", so the logic
should have been `defined param('x') && param('x') ne ''`, but
the method `checkDates` was already explicitly disallowing a "0"
date. Except for the `checkDates` method, the logic was all
simplified to just checking for the truth of `param('x')`, since
"0" was being disallowed in the `checkDates` check anyways.
Add a hidden save submit button first (if showing the assign all
button), so pressing enter in the form will be a save and not an
assign all action.
somiaj
force-pushed
the
user-detail-unassign-confirm
branch
from
October 6, 2026 18:10
29568ef to
cb5d53c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the displayed information on the user detail page.
Add a confirmation modal that appears whenever a set is unchecked to require confirmation. This also adds a hidden field so the unassign on the server side will only unassign if that hidden field had been updated to true.
Add a check to see if any of the dates were actually changed, and only update the database entry in the case a change was made to avoid unneeded database calls.
There was some logic which I believe was trying to allow a set date to be "0", but it wasn't working,
param('x') && param('x') ne ''was being used, which I think was meant to allow "0", so the logic should have beendefined param('x') && param('x') ne '', but the methodcheckDateswas already explicitly disallowing a "0" date. Except for thecheckDatesmethod, the logic was all simplified to just checking for the truth ofparam('x'), since "0" was being disallowed in thecheckDatescheck anyways.Add a hidden save submit button first (if showing the assign all button), so pressing enter in the form will be a save and not an assign all action.