Skip to content

Addressing free(store) in renderd_list not safe for some storages - #524

Merged
hummeltech merged 1 commit into
openstreetmap:masterfrom
hummeltech:FreeStore
Oct 21, 2026
Merged

hummeltech merged 1 commit into
openstreetmap:masterfrom
hummeltech:FreeStore

Conversation

@hummeltech

Copy link
Copy Markdown
Collaborator

Ensures all close_storage methods do not also free store

Closes #66

@codecov

codecov Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.72%. Comparing base (c4e3e62) to head (ac363b5).
⚠️ Report is 52 commits behind head on master.

Files with missing lines Patch % Lines
src/store_rados.c 0.00% 1 Missing ⚠️
src/store_ro_composite.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #524      +/-   ##
==========================================
+ Coverage   81.54%   81.72%   +0.18%     
==========================================
  Files          24       24              
  Lines        5645     5353     -292     
==========================================
- Hits         4603     4375     -228     
+ Misses       1042      978      -64     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hummeltech
hummeltech merged commit 35b470a into openstreetmap:master Oct 21, 2026
37 of 39 checks passed
@hummeltech
hummeltech deleted the FreeStore branch October 21, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

free(store) in renderd_list not safe for some storages

1 participant