docs(about): fix page-context authorship for Ryan Johnson / AMDphreak - #5
Merged
Merged
Conversation
Set page-orig-author to Ryan Johnson with page-orig-author-github so Original author links to https://github.com/AMDphreak instead of crediting OpenShellOrg. Add page-last-author-github so the byline human token amdphreak is linked as well. Co-authored-by: Ryan Johnson <AMDphreak@users.noreply.github.com>
Co-authored-by: Ryan Johnson <AMDphreak@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On https://docs.opensh.org/tools/about/, Original author showed
OpenShellOrg, and the byline human tokenamdphreakwas plain text (no GitHub link).@antora-supplemental/page-contextonly links author names when a GitHub login is known viapage-*-author-githuboverrides or thepage-context-authorsmap. Withpage-orig-author: OpenShellOrgand nopage-last-author-github, there was no profile URL for either surface.Change
Update
docs/modules/about/pages/index.adoc:page-orig-author: Ryan Johnson (not the org)page-orig-author-github: AMDphreak → footer Original author links to https://github.com/AMDphreakpage-last-author-github: AMDphreak → byline keepscursor-agent on behalf of amdphreakbut links amdphreak to the same profileH1, lede, and nav are unchanged. No avatar/CSS workarounds (text-only attribution until page-context’s with-icon switch lands separately).
Changelog
Timeline entry in
CHANGELOG.adoc.