Repository navigation
Fix edit preservation, document imports, and web view isolation - #212
Merged
Merged
Conversation
- After a save, the reader opens the new sheet in one render, not two. - A discard does not render the file again, because the edits are only in the page. - A link to an anchor in the document keeps the edit button and the page messages. - A toast that was never shown still calls its completion. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01878RetqBHQgyMYGfN8Capb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reader could discard edits when covered by a full-screen modal or when switching spreadsheet tabs. Keep documents open behind modals, confirm unsaved changes before navigation, resume editing on the selected sheet, and refresh tabs after reloads.
Also fixes issues found in the codebase review:
Validation: 104 simulator tests, zero failures, one existing toolbar-layout skip; Release device builds for Pro and Lite with signing disabled; screenshot tests compile; formatting passes. Added regression coverage for modal presentation, sheet navigation, imports, HTML messages, search escaping, and page bounds.