feat(scenarios): add meter-value-negative to the corpus - #189
Open
wufangyong973 wants to merge 1 commit into
Open
wufangyong973 wants to merge 1 commit into
wufangyong973 wants to merge 1 commit into
Conversation
METER_VALUE_ANOMALY has two branches and only the decreasing one was exercised. This trace drives the register to -50 Wh, which a cumulative register can never read, so the negative check now has a regression guard. Registers in index.ts and index.test.ts, bumps the external fixture and both README counts, and adds a patch changeset.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #182
METER_VALUE_ANOMALY has two branches and only the decreasing one was covered by the corpus, so a change that dropped the negative check would have sailed through the whole suite. This adds meter-value-negative: a cumulative register that reads -50 Wh, which physically can't happen, driving the negative branch directly.
Files: the scenario itself, registered in index.ts and asserted in index.test.ts (count, name order, getScenario, and an engine run that confirms the failure fires). The external fixture test and both READMEs bump 23 to 24. A patch changeset sits in .changeset since a new scenario does add a public export.