Repository navigation
fix(connected-solid): prevent unintentional resubscription to websocket notifications - #175
Merged
jaxoncreed merged 1 commit intoOct 15, 2026
Conversation
When connection fails unintentionally, it is retried. However we didn't indicate when disconnect was intentional. So it always retried, even after intentional unsubscriptions. This fix addresses that. Additionally try to improve a possible related race condition.
mrkvon
changed the title
mrkvon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When connection fails unintentionally, it is retried. However we didn't indicate when disconnect was intentional. So it always retried, even after intentional unsubscriptions. This lead to reconnection attempt after every unsubscribe.
This fix addresses that.
Additionally I tried to improve a possible related race condition by checking
this.isManualCloseagain after a timeout.I think some race condition still remains:
If connection drops and starts getting established again, and in the meantime the user unsubscribes intentionally, the connection will be reopened and it will flip
this.isManualCloseback tofalse.