fix(script): use registry key for bundler config and proxy lookups - #926
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
📦 Package Size📚 22 runtime dependencies (no change)
All tracked output (25)
Runtime dependencies (22)
Baseline: main_@_b13fadbf___2026-09-22 · gzip is the comparison metric · changes below 16 B gzip are ignored |
harlan-zw
added
harlan-agent-running
Contributor
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe transformer now uses each registry node's canonical Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Severity of issue fixed: Medium Merge Risk: 🟡 Moderate · up to A reported failing test leaves this change not merge-ready until the failure is fixed or explicitly accepted. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Out of Scope Changes checkExplanation The pull request removes the Oxc, PostHog, Nuxt, Unhead, and
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
Author
🤖 MERGED
GitHub merged this pull request. No material findings were recorded. The pull request closed. |
harlan-zw
added
harlan-agent-blocked
harlan-zw
removed
the
harlan-agent-running
harlan-zw
added
harlan-agent-running
The fixture loads the real events.js from analytics.tiktok.com so the delivery test can watch the array protocol drain. It stayed unbundled only because the registry key lookup missed, which this branch fixes. With the lookup correct, the bundle capability applies and the SDK is downloaded and proxied, so the endpoint assertion failed. Also restores pnpm-workspace.yaml, which a local pnpm install pruned.
Merged
1 task
harlan-zw
removed
the
harlan-agent-blocked
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #925
📚 Description
First-party mode silently skipped TikTok Pixel. The bundler guessed the registry key by lowercasing the first letter of the composable name:
useScriptTikTokPixelyieldstikTokPixel, but the registry entry is keyedtiktokPixel. The proxy config lookup missed, so the bundled pixel kept callinganalytics.tiktok.comdirectly instead of going through/_scripts/p/. I hit this through the repro in #925.useScriptLinkedInInsight(→linkedInInsight),useScriptYouTubePlayer(→youTubePlayer), anduseScriptPostHog(→postHog) carried the same divergence. The bundler now reads the key from the matched registry entry instead of deriving it, so config and proxy lookups use the same canonical key as the rest of the module.Before, with
registry: { tiktokPixel: { id: '...' } }and first-party enabled, the stored bundle kept its origin URLs:After, the same build rewrites them through the proxy:
One thing I am unsure about: YouTube Player and PostHog resolve their scripts at runtime, so I could not exercise them through the build-time bundler. They inherit the corrected lookup, but I have no direct test for them.