Skip to content

fix(tui): scroll the changes list - #151

Merged
damusix merged 1 commit into
nextfrom
fix/tui-change-list-scroll
Nov 17, 2026
Merged

damusix merged 1 commit into
nextfrom
fix/tui-change-list-scroll

Conversation

@damusix

@damusix damusix commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

The Changes screen drew every change at once. With more changes than terminal rows, the list squashed, the newest changes fell out of view, and the hotkeys and status bar left the screen.

  • Changes screen: windows through SelectList, with ↑ N more / ↓ N more lines. The detail box is fixed at three lines and is dropped on a terminal too short to hold it.
  • Failed changes: the box shows one truncated error line with a pointer to [h] History. The full error is no longer printed inline.
  • All terminal-sized lists (SelectList, SearchableList, FilePicker) count their indicator lines inside the row budget. Before, they drew one or two rows past it.

docs/public/image/tui/changes-list.png is regenerated through shots.sh.

Before and after, 42 changes on a 32-line terminal, cursor on the oldest change:

Before: list squashed, oldest change out of view

After: list scrolled to the oldest change, hotkeys visible

After: cursor mid-list, both scroll indicators

Before: 24 lines, layout collapses

After: 24 lines, detail box dropped, list and hotkeys fit

The Changes screen drew every change at once, so a long list squashed
the newest changes and pushed the hotkeys off screen. It now windows
through SelectList with a fixed three-line detail box that drops on
short terminals.

SelectList, SearchableList and FilePicker now count their scroll
indicator lines inside the row budget instead of drawing past it.
@damusix
damusix marked this pull request as ready for review November 17, 2026 05:23
@damusix
damusix merged commit c26eae5 into next Nov 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant