Repository navigation
fix(tui): scroll the changes list - #151
Merged
Merged
Conversation
The Changes screen drew every change at once, so a long list squashed the newest changes and pushed the hotkeys off screen. It now windows through SelectList with a fixed three-line detail box that drops on short terminals. SelectList, SearchableList and FilePicker now count their scroll indicator lines inside the row budget instead of drawing past it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Changes screen drew every change at once. With more changes than terminal rows, the list squashed, the newest changes fell out of view, and the hotkeys and status bar left the screen.
SelectList, with↑ N more/↓ N morelines. The detail box is fixed at three lines and is dropped on a terminal too short to hold it.[h] History. The full error is no longer printed inline.SelectList,SearchableList,FilePicker) count their indicator lines inside the row budget. Before, they drew one or two rows past it.docs/public/image/tui/changes-list.pngis regenerated throughshots.sh.Before and after, 42 changes on a 32-line terminal, cursor on the oldest change: