Skip to content

doc: add return type to Blocklist.isBlocklist - #66181

Open
motokaneyuki wants to merge 1 commit into
nodejs:mainfrom
motokaneyuki:doc-net-isblocklist-return-types
Open

motokaneyuki wants to merge 1 commit into
nodejs:mainfrom
motokaneyuki:doc-net-isblocklist-return-types

Conversation

@motokaneyuki

@motokaneyuki motokaneyuki commented Sep 21, 2026

Copy link
Copy Markdown

This adds missing return type for Blocklist.isBlocklist.

According to what this function returns:

static isBlockList(value) {
return value?.[kHandle] !== undefined;
}

Refs: nodejs/doc-kit#953

Signed-off-by: Yuki Motokane <216834584+motokaneyuki@users.noreply.github.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. net Issues and PRs related to the net subsystem. labels Sep 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Welcome to Node.js, and thank you for your first contribution!

Before review, please take a moment to read:

Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal.

@inoway46 inoway46 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. doc Issues and PRs related to Node.js documentation. net Issues and PRs related to the net subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants