fix(core): validate plot edits and retain unrelated analysis results by nmrtist · Pull Request #133 · nmrtist/plotium

nmrtist · 2026-10-24T13:38:55Z

Summary

Prevent table and shared-axis edits from leaving plots invalid, and retain CRAFT results when unrelated datasets are deleted.

Reject table patches and refreshes that invalidate existing curve bindings before changing document state or Undo history.
Reject conflicting shared X settings in one transaction while accepting equivalent ranges in compatible units.
Tie CRAFT and direct DOSY/ILT completions to dataset IDs and task generations; cancel work for removed sources.
Update the English and Simplified Chinese guides.

cargo pr-check: passed.
Regression tests cover rejected edits, Undo/Redo, save/reopen in both snapshot modes, shared-axis conflicts and unit conversion, and analysis completion after deletion, restoration and project replacement.
npm run build in docs/: passed.

nmrtist added 4 commits October 24, 2026 21:07

fix(core): reject table updates that invalidate plotted curves

9da51c9

fix(axes): reject conflicting shared x edits atomically

a4f02f6

fix(core): retain analyses across unrelated dataset deletion

6f152e4

Merge main and preserve shared X axis regression tests

c3ee111

nmrtist merged commit 4405dca into main Oct 25, 2026
11 checks passed

nmrtist deleted the fix/edit-state-correctness branch October 25, 2026 05:12